Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX : display error when loan can't be deleted #32338

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

thomas-Ngr
Copy link
Contributor

@thomas-Ngr thomas-Ngr commented Dec 12, 2024

FIX On loan, if a payment bank line is conciliated, the loan can't be deleted but there is no error.

Bug seen on DLB 18 and develop. I guess it is also buggy inbetween.

On loan, if a payment bank line is conciliated, the loan can't be deleted.
This is good, but the user should receive an error.

To reproduce :

  • Module loan must be activated
  • a bank account should exist
  • create a loan (htdocs/loan/list.php)
  • create a payment for this loan
  • navigate to the bank line related to the payment
  • Reconciliate the bank line by entering any account statement.
  • now try to delete the loan :
    • the loan is not deleted
    • you don't get any error

This PR makes the error visible in the webUI.

Copy link
Contributor

@rycks rycks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@eldy eldy merged commit 60ea952 into Dolibarr:18.0 Jan 15, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants