FIX avoid pgsql error #31360
FIX avoid pgsql error #31360
Conversation
htdocs/societe/contact.php
Outdated
| $contact = new Contact($db); | ||
|
|
||
| $result = $contact->fetch($id); | ||
| $contact->oldcopy = clone $contact; |
There was a problem hiding this comment.
You'll have to ignore this one.
// @phan-suppress-current-line PhanTypeMismatchProperty
I opened a phan issue for this yesterday: phan/phan#4883 .
|
|
||
| $sql = "DELETE t, et FROM ".MAIN_DB_PREFIX."socpeople AS t"; | ||
| $sql .= " LEFT JOIN ".MAIN_DB_PREFIX."socpeople_extrafields AS et ON t.rowid = et.fk_object"; | ||
| $sql .= " WHERE t.fk_soc = ".((int) $socid); |
There was a problem hiding this comment.
Using the fetch then delete will break the control on owner of contact.
Why not just removing the left join on the delete ?
There was a problem hiding this comment.
@eldy i use the "delete" function of contact class, same code inside the contact card for delete action. Maybe add this verification in "delete" function of contact class no ?
eldy
added
the
Discussion
| $db->commit(); | ||
| $contact = new Contact($db); | ||
|
|
||
| $result = $contact->fetch($id); |
There was a problem hiding this comment.
There's no more error checking on the fetch() operation. Should it be checked also?
|
@eldy et quid des autres tables qu'on nettoie lorsqu'on utilise la fonction delete de la classe contact lorsqu'on supprime un contact à partir de sa fiche ? Et du coup le trigger n'est pas appelé non plus !! |
You are right. I was confused by the label of PR: fix pgsql sql error. |
|
J'aime voir des bugs se régler au fur et à mesure de les voir et de les comprendre... Ne pas comprendre les bugs c'est ne pas comprendre Dolibarr... |
No description provided.