NEW : Add option position['find'] to DolEditor #29546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 30, 2024 11:47
eldy
reviewed
May 1, 2024
| @@ -301,12 +305,14 @@ public function __construct($db) | |||
| $this->rights[$r][5] = 'delete'; // In php code, permission will be checked by test if ($user->hasRight('mymodule', 'myobject', 'delete')) | |||
| $r++; | |||
| */ | |||
| // Add here entries to declare new permissions | |||
| /* BEGIN MODULEBUILDER PERMISSIONS */ | |||
There was a problem hiding this comment.
The BEGIN MODULEBUILDER PERMISSINS must be before the example, because when we add apermission, 1 by 1, it is the content inside the block that is used to copy and generated a new block.
eldy
reviewed
May 1, 2024
| @@ -179,8 +182,7 @@ public function __construct($db) | |||
| $conf->mymodule->enabled = 0; | |||
| } | |||
|
|
|||
| // Array to add new pages in new tabs | |||
| $this->tabs = array(); | |||
There was a problem hiding this comment.
Like for Permissions, I've moved it after the examples, because i thought seeing some pattern but it seems i've only seen it for Dictionnaries.
(Currently reverting it to what it was)
eldy
added
the
Discussion
|
I've manually "revert" the template descriptor file to what it was before my PR, only adding some new flags (HOOKSCONTEXTS, DESCRIPTION_FLAG and TABS). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding the possibility to find a word inside a content opened by DolEditor, it allow to go to the first line matching the word.
It is usefull for long and diverses files, like the descriptor file of a module.
The module builder was adapted to use this parameter and open the descriptor file directly to the flagged line.
By "word", it allow the possibility to use textual flags inside a document.