Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when invoice is created by WORKFLOW_ORDER_AUTOCREATE_INVOICE on ORDER_CLOSE, the invoice must have the default bank account of the thirdparty is it's empty on order #29462

Merged
merged 3 commits into from
Apr 27, 2024

Conversation

FHenry
Copy link
Member

@FHenry FHenry commented Apr 24, 2024

No description provided.

…ORDER_CLOSE, the invoice must have the default bank account of the thirdparty is it's empty on order
@eldy
Copy link
Member

eldy commented Apr 25, 2024

If the bank account is empty on order, it is probable because the user has removed the value on the order (otherwise it is set with the default value of the thirdparty on order).
So if the user has removed the default value on order, it is surely because it don't want to have a bank account forced on order and on invoice.
If a default bank account has been defined on thirdparty, it will be set on order and already propagated on invoice.
And if empty on order, it is because user has removed it on purpose so don't want to have it forced on PDF. So no reason to have it forced on PDF. Di i miss something ?

@eldy eldy added the Discussion Some questions or discussions are opened and wait answers of author or other people to be processed label Apr 25, 2024
@FHenry
Copy link
Member Author

FHenry commented Apr 25, 2024

I will be agree if on clone order on another thirdparty that default bank account on the clones one where be taken from the "another thirdparty"
and but bank account on order is optionnal (const BANK_ASK_PAYMENT_BANK_DURING_ORDER not enabled by default)

So may be If I test this BANK_ASK_PAYMENT_BANK_DURING_ORDER is empty, it means user cannot set bank on order, then it have to come from thirdparty ?

@eldy eldy merged commit 7688461 into Dolibarr:17.0 Apr 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Some questions or discussions are opened and wait answers of author or other people to be processed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants