Qual: Fix/complete/refactor ModuleTest case. #28373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Fix: Correct CommonClassTest's constructor Dataproviders did not work because of the issue with the constructor
# Qual: Refactor module name list, add mapping to class name Based on ModuleTest and search for modules in the code, complete the list of modules and map to the class names. This will allow reuse in the ModuleTest.
# Qual: Refactor ModulesInit test Use the updated common module mapping list, more complete than the original list. Also refactor the test to use a data provider.
mdeweerd
force-pushed
the
modules/refactor_extend_test
branch
from
5d90855 to
e41d058
Compare
# Fix: valid module test must now use array_key_exists Because of the introduction of null key values, isset on the array no longer works, using array_key_exists to test if the modulename is valid.
# Qual: Less verbosity for tests The verbosity on setup/teardown/... is not really usefull and makes the log less readable. Reducing the verbosity while allowing to set an environment variable PHPUNIT_DEBUG to enable it.
eldy
reviewed
Feb 23, 2024
| 'ReceiptPrinter','Reception','Recruitment','Resource', | ||
| 'Salaries','Service','SocialNetworks','Societe','Stock','Stripe','SupplierProposal','Syslog', | ||
| 'TakePos','Tax','Ticket','User','Variants','WebServices','WebServicesClient','Website','Workflow','Workstation','Zapier'); | ||
| foreach ($modulelist as $modlabel) { |
There was a problem hiding this comment.
I don't understand where is the foreach after the change ?
There was a problem hiding this comment.
I used the "dataProvider" feature from PHPunit.
moduleInitListProvider() provides the arguments to pass on to the test function - phpunit loops over that list of lists of arguments and executes the test as an independent test.
eldy
added
the
Discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Correct CommonClassTest's constructor
Dataproviders did not work because of the issue with the constructor
Qual: Refactor module name list, add mapping to class name
Based on ModuleTest and search for modules in the code, complete the
list of modules and map to the class names.
This will allow reuse in the ModuleTest.
Qual: Refactor ModulesInit test
Use the updated common module mapping list, more complete than
the original list.
Also refactor the test to use a data provider.
Note
Module list needs review/completion.