Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Shipment closing action has wrong value #28174

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

n15c
Copy link
Contributor

@n15c n15c commented Feb 14, 2024

Change the value of the action parameter from "close" to "classifyclosed" to make the button work again.

Change the value of the action parameter from "close" to "classifyclosed" to make the button work again.
@JonBendtsen
Copy link
Contributor

There are 14 other files that also contain action=close&token= I wonder if they should also be changed to classifyclosed?

Further more, not all the lines are formatted the same way, some use dolGetButtonAction others <a class="butActionDelete" and a <div class="inline-block divButAction"><a class="butAction

Some of the dolGetButtonAction has a dolGetButtonAction('', $langs->trans others dolGetButtonAction($langs->trans(

@eldy eldy merged commit 5315b60 into Dolibarr:develop Feb 15, 2024
4 checks passed
eldy pushed a commit that referenced this pull request Feb 15, 2024
Change the value of the action parameter from "close" to "classifyclosed" to make the button work again.
@n15c n15c deleted the FIX-Shipment-closing branch April 2, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants