Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX check parameter socid before cloning a customer proposal #28085

Merged
merged 1 commit into from
Feb 9, 2024
Merged

FIX check parameter socid before cloning a customer proposal #28085

merged 1 commit into from
Feb 9, 2024

Conversation

lvessiller-opendsi
Copy link
Contributor

FIX check parameter "socid" before cloning a customer proposal

  • the check "GETPOST('socid', 3)" has a wrong parameter "3" (the second parameter of GETPOST is the type of field "alpha", "int", "alphanohtml", etc)
  • the event message "NoCloneOptionsSpecified" is a wrong message for the user and it's unuseful here

So I replaced with a check of "socid" and if this parameter is not positive, I put a required field error message.

@lvessiller-opendsi lvessiller-opendsi mentioned this pull request Feb 9, 2024
Merged
@eldy eldy merged commit e3ad92d into Dolibarr:18.0 Feb 9, 2024
4 checks passed
@lvessiller-opendsi lvessiller-opendsi deleted the 18.0_fix-propal-clone-check-socid branch February 9, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lvessiller-opendsi @eldy