Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX contract service list status filter (v18+) #27970

Closed

Conversation

W1W1-M
Copy link
Contributor

@W1W1-M W1W1-M commented Feb 2, 2024

FIX contract service list status filter

In the current implementation of the service list, a $filter variable is used in pair with the $search_status variable in order to filter the results. In some use cases the list isn't properly filtered and the results do not correspond to the filter requested by the user:

  • Using the contract services submenu link Expired services gives you expired and not expired services
  • Switching between states and then back to running state doesn't filter correctly

Here are the steps to reproduce it :

  1. Set up some services in all the different states : inactif, running not expired, running expired and closed.
  2. Switch between filter states and observe listed contracts

I can also repeat the problem on develop branch.

Also, try switching between different states and observe that the filter variable in $_POST is not always correctly set.

This PR removes the $filter variable and makes better use of the $search_status variable for list filtering. EN & FR localizations have also been updated for clearer list titles for expired and not expired lists.

The bug is a little subtle but it's there if you look.

This PR is related to issue #26283

This PR is a backport of #26664

@W1W1-M W1W1-M changed the title FIX contract service list status filter FIX contract service list status filter (v18+) Feb 2, 2024
eldy added a commit that referenced this pull request Feb 3, 2024
@eldy eldy closed this Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants