FIX contract service list status filter (v18+) #27970
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX contract service list status filter
In the current implementation of the service list, a
$filter
variable is used in pair with the$search_status
variable in order to filter the results. In some use cases the list isn't properly filtered and the results do not correspond to the filter requested by the user:running
state doesn't filter correctlyHere are the steps to reproduce it :
I can also repeat the problem on develop branch.
Also, try switching between different states and observe that the filter variable in $_POST is not always correctly set.
This PR removes the
$filter
variable and makes better use of the$search_status
variable for list filtering. EN & FR localizations have also been updated for clearer list titles for expired and not expired lists.The bug is a little subtle but it's there if you look.
This PR is related to issue #26283
This PR is a backport of #26664