Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: use the currency for propal signature page #27751

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

Slordef
Copy link
Contributor

@Slordef Slordef commented Jan 23, 2024

FIX Signature of propal now use the propal currency

From a client point of view, it is more pleasant to have the currency of the proposal which automatically comes from the client's currency during creation.

Of course, even if we do not activate "multicurrency" in the modules, the multicurrency_code and multicurrency_total_ttc fields are correctly used

@eldy
Copy link
Member

eldy commented Jan 23, 2024

I think we should show both when object is multicurrency object.
The main currency (because this is the value that will be requested at the bank and used into accountancy). And if the proposal is mutlicurrency, we show the amount in parenthesis. For example
Amount: 30 € ($28)
Can you enhance in this direction ?

@eldy eldy added the Discussion Some questions or discussions are opened and wait answers of author or other people to be processed label Jan 23, 2024
@Slordef
Copy link
Contributor Author

Slordef commented Jan 23, 2024

@eldy sounds good

while currency of propal is not the same as global currency, we show both with propal currency in parentheses
@Slordef
Copy link
Contributor Author

Slordef commented Jan 23, 2024

@eldy After discuss with @Amael-PE
We came to the conclusion that it is still preferable to only show the customer's currency since it is only him who will have this document.
As for the accounting data, that's another part.

Should we ?

@Amael-PE
Copy link
Contributor

Hey here,
Indeed, our use case is the following: Albert is working in a large French company and can accept/sign up to 5000€.

  • I sell Albert a service S, whose price is 3000 CHF. As Albert is in France, I offer 3100 €
  • Once th offer is done I want to send the link to sign to Albert... But I need him to see the 3100 €, cause he is French and doesn't care about our Swiss prices.

If we show a CHF price (main currency), I will only confuse Albert. He will go to the management etc and it will only make thnigs longer... Better send an email then

I hope our use case is clear !
An thanks for the amazing work on Dolibarr !

@eldy eldy merged commit 2e620ba into Dolibarr:18.0 Jan 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Some questions or discussions are opened and wait answers of author or other people to be processed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants