Fix: formmail - add_attached_files - argument name consistency #27338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Fix: formmail - add_attached_files - argument name consistency Phan determined suspicious naming as arg Dolibarr#2 to add_attached_files is while that was the name for the first argument by the caller. Also, on examination, only the first parameter is needed as add_attached_files handles the other two in the same manner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: formmail - add_attached_files - argument name consistency
Phan determined suspicious naming as arg #2 to add_attached_files is while
that was the name for the first argument by the caller.
Also, on examination, only the first parameter is needed as add_attached_files
handles the other two in the same manner.