-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEW #24031 add option MAIN_GRANDTOTAL_LIST_SHOW to always show grand total to lists #27247
Merged
eldy
merged 8 commits into
Dolibarr:develop
from
vmaury:Fix_#24032_Add_grandtotal_to_lists
Feb 12, 2024
Merged
NEW #24031 add option MAIN_GRANDTOTAL_LIST_SHOW to always show grand total to lists #27247
eldy
merged 8 commits into
Dolibarr:develop
from
vmaury:Fix_#24032_Add_grandtotal_to_lists
Feb 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
changed the title
Fix #24031 add - if option selected - grand total to lists
NEW #24031 add - if option selected - grand total to lists
Jan 2, 2024
Can you provide a screenshot of result ? |
eldy
reviewed
Jan 12, 2024
$sumsarray = false; | ||
$tbsumfields = []; | ||
foreach ($totalarray['pos'] as $field) { | ||
$tbsumfields[] = "sum($field) as `$field`"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use of backtick ` is forbidden in SQL as it is not a SQL standard.
May be you can do:
$fieldforsum = preg_replace('/[^a-z0-9]/', '', $field);
$tbsumfields[] = "sum($field) as $fieldforsum";
eldy
added
the
PR to fix - See feedback in comments
PR needs to be fixed to be integrated (some comments should describes the fix to do)
label
Jan 12, 2024
…randtotal_to_lists
eldy
changed the title
NEW #24031 add - if option selected - grand total to lists
NEW #24031 add option MAIN_GRANDTOTAL_LIST_SHOW to always show grand total to lists
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PR to fix - See feedback in comments
PR needs to be fixed to be integrated (some comments should describes the fix to do)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#Fix #24031 add - if option selected - grand total to lists
The grand total displays :
Translations done in english and french