FIX: possible inconsistency between llx_ecm_files and file system when BILL_SUPPLIER_VALIDATES changes ref #27008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gger but we still use a local variable for the filesystem-based renaming
atm-florianm
deleted the
FIX_17_trigger_BILL_SUPPLIER_VALIDATE_cannot_modify_newref
branch
atm-florianm
added a commit
to ATM-Consulting/dolibarr
that referenced
this pull request
Mar 7, 2024
…ding to inconsistencies if BILL_SUPPLIER_VALIDATE changes the invoice's ref this is a follow-up of PR Dolibarr#27008
atm-florianm
added a commit
to ATM-Consulting/dolibarr
that referenced
this pull request
Mar 7, 2024
…ding to inconsistencies if BILL_SUPPLIER_VALIDATE changes the invoice's ref this is a follow-up of PR Dolibarr#27008
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX possible inconsistency
When you validate a supplier invoice, its ref changes and so does the name of the directory that stores attachments.
Currently, the renaming is using two variables:
$this->newrefand$newref.$this->newrefis used for the ECM renaming$newrefis used for the file system renaming.Most of the time, both variable have the exact same value, so there is no problem, but if a module implementing the
BILL_SUPPLIER_VALIDATEtrigger changes$this->newref, we end up with entries inllx_ecm_fileswith wrong paths because the actual file system renaming will use$newref, which the trigger cannot modify.This fix ensures we use only
$this->newrefso that no inconsistency arises between ECM files and file system and enables triggers to modify the invoice's ref without “losing” its attachments.