FIX Update stockatdate.php #26481
Merged
FIX Update stockatdate.php #26481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As commented in Dolibarr#23782 this update is to clean and clarify the code for future evolution of stocktodate. In fact the calculated value in the SQL request is the current stock value and not the estimated stock value at date value. Therefore I changed in SQL request the estimatedvalue to currentvalue and reused as a variable for a better understanding and for future use (other PR) as it will be interesting to get a comparison between stockatdate value to currentstock value. Also some others changes are required to improve the page speed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As commented in #23782 this second FIX update is to clean and clarify the code for future evolution of stockatdate.
In fact the calculated value in the SQL request is the current stock value and not the estimated stock value at date value. Therefore I changed in the SQL request the estimatedvalue to currentvalue and reused it later in the code as a variable for a better understanding and for future use (other PRs) as it will be interesting to get a comparison between stockatdate value to currentstock value. Also some others changes are required to improve the page speed.