FIX : HTML in ODT templates #26181
Merged
FIX : HTML in ODT templates #26181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems a different fix were done in v18. |
eldy
added
the
Discussion
|
I copied what was done in V18, this does not seem to pose a compatibility problem I also modified the regexp a little (it did not target all of the tags) |
eldy
reviewed
Oct 13, 2023
htdocs/includes/odtphp/odf.php
Outdated
| pclose($handlein); | ||
| fclose($handle); | ||
| } | ||
| dolChmod($outputfile); |
There was a problem hiding this comment.
@atm-adrien
With v17, this line of code will hang. Keep v17 code as this has no relation with the bugfix.
eldy
added
PR to fix - See feedback in comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX : HTML in ODT templates
There is currently no interpretation of HTML in ODT type document templates.
Here is what we have in entry :
<p><strong><u>DESCRIPTION DES PRODUITS</u></strong><br /> Ceci est un produit & un service<br /> Contrôle des stock de ce produit <br /> Vérification des dispositifs d'installation pour ce produit <br /> Vidange des filtres à carburant supplémentaire pour ce produit <br /> N° de ce produit</p>We have the same thing written in our ODT document