Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEW - Row in list higher height #26177

Merged
merged 6 commits into from
Oct 12, 2023
Merged

NEW - Row in list higher height #26177

merged 6 commits into from
Oct 12, 2023

Conversation

BB2A-Anthony
Copy link
Contributor

@BB2A-Anthony BB2A-Anthony commented Oct 10, 2023 •
edited
Loading

NEW|New [Row in list higher height]

[Long description]

To have better readability and give modernism
image

@eldy
Copy link
Member

eldy commented Oct 10, 2023

Can you show a screen shot to see what is the diff on ?

@eldy eldy added the PR waiting more user feedbacks We are waiting feedback of someone or more testers to validate this PR label Oct 10, 2023
@BB2A-Anthony
Copy link
Contributor Author

Can you show a screen shot to see what is the diff on ?

image

@eldy
Copy link
Member

eldy commented Oct 10, 2023 •
edited
Loading

This is interesting for the first "wow-effect" (Very important to adopt dolibarr), but may have bad effect for the day-to-day usage by reducing the number of lines visible on screen.
I think we can introduce an option into the display page to choose "Table line spacing" between "compact" or "large" ?
We can use the large by default (on first install for the wow-effect, but we allow end user to retrieve a compact mode for day to day usage)

@BB2A-Anthony
Copy link
Contributor Author

This is interesting for the first "wow-effect" (Very important to adopt dolibarr), but may have bad effect for the day-to-day usage by reducing the number of lines visible on screen. I think we can introduce an option into the display page to choose "Table line spacing" between "compact" or "large" ? We can use the large by default (on first install but we allow end user to retrieve a compact mode for day to day usage)

@eldy it's done

@eldy eldy merged commit a29616d into Dolibarr:develop Oct 12, 2023
1 of 2 checks passed
@BB2A-Anthony BB2A-Anthony deleted the NEW---Line-be-most-height-in-list branch October 12, 2023 14:52
BB2A-Anthony pushed a commit to BB2A-Anthony/dolibarr that referenced this pull request Oct 17, 2023
FIX - Row in list higher height PR Dolibarr#26177
5000504
@BB2A-Anthony BB2A-Anthony mentioned this pull request Oct 17, 2023
Closed
eldy added a commit to BB2A-Anthony/dolibarr that referenced this pull request Oct 18, 2023
@eldy
Merge branch 'develop' into FIX---Row-in-list-higher-height-PR-Doliba…
1e339ab 
…rr#26177
BB2A-Anthony pushed a commit to BB2A-Anthony/dolibarr that referenced this pull request Oct 26, 2023
Merge branch 'FIX---Row-in-list-higher-height-PR-Dolibarr#26177' of h…
31370a8 
…ttps://github.com/bb2a/dolibarr; branch 'develop' of https://github.com/Dolibarr/dolibarr into FIX---Row-in-list-higher-height-PR-Dolibarr#26177
BB2A-Anthony added a commit to BB2A-Anthony/dolibarr that referenced this pull request Feb 26, 2024
@BB2A-Anthony
Merge branch 'develop' into FIX---Row-in-list-higher-height-PR-Doliba…
025661e 
…rr#26177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR waiting more user feedbacks We are waiting feedback of someone or more testers to validate this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BB2A-Anthony @eldy