-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEW Can switch product batch management to no management. #21691
NEW Can switch product batch management to no management. #21691
Conversation
…tion of each batch stock mouvement in global stock mouvement
…thub.com:atm-adrien/dolibarr into NEW_BatchStockMouvements_to_GlobalStockMouvement
…StockMouvements_to_GlobalStockMouvement
Hi @eldy, in this PR i did corrections you asked to @atm-adrien (old PR : #21503). |
…thub.com:atm-gauthier/dolibarr into NEW_BatchStockMouvements_to_GlobalStockMouvement
…StockMouvements_to_GlobalStockMouvement
…ble on product edit if its current status batch is "Yes (lot required)"
…StockMouvements_to_GlobalStockMouvement
Hi @eldy, you can see here what's added : First i we stop using serial numbers or batch, this message appears : Second thing if our product status batch was batch, we'll no longer be able to choose serial number, because Dolibarr doesn't know in which serial number dispatch each quantity : |
Ok for first point. For the second point, Switching first to "no" choice, to "delete" existing serial seems is a bad idea as we will loose information. For example we may want to convert lot A into Lot A-1, Lot A-2, ... and lot B into Lot B into Lot B-1, Lot B-2. |
…StockMouvements_to_GlobalStockMouvement
…thub.com:atm-gauthier/dolibarr into NEW_BatchStockMouvements_to_GlobalStockMouvement
htdocs/product/card.php
Outdated
@@ -1944,7 +1944,45 @@ | |||
if ($object->isProduct() || !empty($conf->global->STOCK_SUPPORTS_SERVICES)) { | |||
print '<tr><td>'.$langs->trans("ManageLotSerial").'</td><td>'; | |||
$statutarray = array('0' => $langs->trans("ProductStatusNotOnBatch"), '1' => $langs->trans("ProductStatusOnBatch"), '2' => $langs->trans("ProductStatusOnSerial")); | |||
print $form->selectarray('status_batch', $statutarray, (GETPOSTISSET('status_batch') ? GETPOST('status_batch') : $object->status_batch)); | |||
|
|||
print $form->selectarray('status_batch', $statutarray, $object->status_batch); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On error, we should not lose the user initial delection, so can you restore the test on GETPOSTISSET in current line of code ?
No description provided.