Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove € + unsed code and file #12768

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Remove € + unsed code and file #12768

merged 1 commit into from
Jan 13, 2020

Conversation

atm-maxime
Copy link
Member

#12496 again

@eldy
Copy link
Member

eldy commented Dec 31, 2019

@aspangaro Can you confirm we can remove the createschedule.php page ?

@eldy eldy added PR waiting more user feedbacks We are waiting feedback of someone or more testers to validate this PR PR OK to merge PR was analyzed by PR merger and seems ok to be validated. Merge may occurs soon... labels Dec 31, 2019
@atm-maxime
Copy link
Member Author

@eldy I checked and this page was only called by the js function that was commented. Now the schedule is a tab on the loan card, schedule.php

@aspangaro
Copy link
Member

@eldy, the modification seems good for me. You can merge

@eldy eldy merged commit f94b3e5 into Dolibarr:11.0 Jan 13, 2020
@atm-maxime atm-maxime deleted the fix_loan_currency2 branch May 9, 2020 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR OK to merge PR was analyzed by PR merger and seems ok to be validated. Merge may occurs soon... PR waiting more user feedbacks We are waiting feedback of someone or more testers to validate this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atm-maxime @eldy @aspangaro