Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thirdparty merging doesn't work if Donation module or Ticket module is not activated #24985

Closed
thibdrev opened this issue Jun 7, 2023 · 1 comment
Assignees
Labels
Bug This is a bug (something does not work as expected) Event: DevCamp 2023 Bordeaux

Comments

@thibdrev
Copy link
Contributor

thibdrev commented Jun 7, 2023

Bug

When trying to merge two thirdparties:

  • if Donation module is not activated then Dolibarr throws an error message stating that table dolibarr.llx_don doesn't exist.
  • if Ticket module is not activated then Dolibarr throws an error message stating that table dolibarr.llx_ticket doesn't exist.

Activating both modules solves the issue but is probably not the right behaviour.

Refer also to this message on the French Dolibarr forum: Fusion de tiers table don’t exist.

Environment Version

16.0.5

Environment OS

Linux

Environment Web server

Apache

Environment PHP

7.4

Environment Database

MariaDB

Environment URL(s)

No response

Expected and actual behavior

Thirdparties shall merge flawlessly, with no error message prompted.

Steps to reproduce the behavior

Step 1

  • Go to a thirdparty card (/societe/card.php?socid=n)
  • Click "Merge".
  • Select the thirdparty to be merged with.
  • Click “Yes”.

Dolibarr prompts an error message:

Table 'dolibarr.llx_don' doesn't exist
Echec de la fusion de 2 enregistrements. Demande annulée.

(please also note that the first sentence of the error message is not translated).

Step 2

  • Activate the Donation module.
  • Repeat Step 1.

Dolibarr prompts another error message:

Table 'dolibarr.llx_ticket' doesn't exist
Echec de la fusion de 2 enregistrements. Demande annulée. »

Step 3

  • Activate the Ticket module.
  • Repeat Step 1.

Now Dolibarr prompts an OK message: Les tiers ont été fusionnés.

Attached files

No response

@thibdrev thibdrev added the Bug This is a bug (something does not work as expected) label Jun 7, 2023
@aspangaro aspangaro self-assigned this Jun 8, 2023
aspangaro added a commit to aspangaro/dolibarr that referenced this issue Jun 8, 2023
…with module whose tables are not deployed by default
eldy added a commit that referenced this issue Jun 8, 2023
FIX #24985 Societe - Function thirdparty merging not working with module whose tables are not deployed by default
@thibdrev
Copy link
Contributor Author

thibdrev commented Jun 9, 2023

Au top.
Merci à tous !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug (something does not work as expected) Event: DevCamp 2023 Bordeaux
Projects
None yet
Development

No branches or pull requests

3 participants