Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in activity structs for activity_table.json #17

Merged
merged 20 commits into from
Sep 1, 2024
Merged

Add in activity structs for activity_table.json #17

merged 20 commits into from
Sep 1, 2024

Conversation

RenzVEVO
Copy link
Contributor

@RenzVEVO RenzVEVO commented Sep 1, 2024

Double check if I miss anything then let me know which part i need to change/edit.

Rhelvetican
Rhelvetican requested changes Sep 1, 2024
View reviewed changes
Copy link
Contributor

@Rhelvetican Rhelvetican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove #[serde(rename_all = "camelCase")] for empty / unit structs

@Rhelvetican Rhelvetican added this to the 0.7 milestone Sep 1, 2024
@RenzVEVO
Copy link
Contributor Author

RenzVEVO commented Sep 1, 2024

Should be good now. Take another look when you have time.

RenzVEVO
RenzVEVO commented Sep 1, 2024
View reviewed changes
Copy link
Contributor Author

@RenzVEVO RenzVEVO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here

Rhelvetican
Rhelvetican requested changes Sep 1, 2024
View reviewed changes
Copy link
Contributor

@Rhelvetican Rhelvetican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually let's remove any mention of it altogether as it's not used in the logic.

@RenzVEVO
Copy link
Contributor Author

RenzVEVO commented Sep 1, 2024

Here you go

Rhelvetican
Rhelvetican approved these changes Sep 1, 2024
View reviewed changes
Copy link
Contributor

@Rhelvetican Rhelvetican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@Rhelvetican Rhelvetican merged commit f7cd64f into DoctorateRS:main Sep 1, 2024
@RenzVEVO RenzVEVO deleted the rlv2 branch September 9, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rhelvetican Rhelvetican Rhelvetican approved these changes

Assignees

@RenzVEVO RenzVEVO

Labels
None yet
Projects
None yet
Milestone
0.7
Development

Successfully merging this pull request may close these issues.
2 participants
@RenzVEVO @Rhelvetican