Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1049 Migrate developer documentation to main repository #1088

Merged

Conversation

GuusLieben
Copy link
Member

@GuusLieben GuusLieben commented May 20, 2024

Type of Change

  • Documentation (documentation changes)
  • Chore (changes to the build process or auxiliary tools)

Description

Summary

Currently our documentation is developed and maintained at https://github.com/Dockbox-OSS/HartshornDocs. While this is a convenient setup, it makes it hard to keep documentation up to date for new releases. As such, these changes migrate our documentation away from mkdocs, and now allow us to place documentation directly in our various modules, and publish using Antora.

Writing and building

Documentation can be written using the Asciidoc format, and can be published either locally (unversioned) or for release (versioned) using pre-made playbooks in our assembly directory.

Custom UI bundle

To customize the look and feel of our documentation, we have a custom UI bundle which is developed at https://github.com/Dockbox-OSS/Antora-Dockbox-UI. A sample of this UI bundle can be seen below.

image

CI integration

To automatically check for documentation issues, and optionally get a quick preview of the documentation for a specific pull request, a CI workflow has been added to build and publish the documentation. An overview of executions of this workflow can be found at https://github.com/Dockbox-OSS/Hartshorn/actions/workflows/build.docs.yml. Note that artifacts are only retained for 7 days.

Checklist

  • I have performed a self-review of my own code
  • Related issue number is linked in pull request title
  • I have added documentation that describes my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have rebased my branch on top of the latest develop branch

Related Issue

Closes #1049

@GuusLieben GuusLieben added this to the Release 0.6.0 milestone May 20, 2024
@GuusLieben GuusLieben self-assigned this May 20, 2024
@GuusLieben
Copy link
Member Author

GuusLieben commented May 20, 2024

Pending work:

  • Correct icon for 'View on GitHub' on production
  • Correct paths for 'edit this page'
  • Integrate Antora execution into CI

@GuusLieben GuusLieben force-pushed the feature/#1049-developer-documentation branch 3 times, most recently from 7678bfa to 7c1f8c8 Compare July 20, 2024 12:49
@GuusLieben GuusLieben force-pushed the feature/#1049-developer-documentation branch from 7c1f8c8 to 0729a33 Compare July 29, 2024 18:12
@GuusLieben GuusLieben changed the base branch from develop/0.6.0 to develop/0.6.0-modules July 29, 2024 18:12
@GuusLieben GuusLieben force-pushed the feature/#1049-developer-documentation branch from 0729a33 to 6f375d2 Compare July 31, 2024 17:32
@GuusLieben GuusLieben changed the base branch from develop/0.6.0-modules to feature/#1092-module-migration July 31, 2024 17:32
@GuusLieben GuusLieben force-pushed the feature/#1049-developer-documentation branch from 6f375d2 to 7463981 Compare July 31, 2024 18:13
@GuusLieben GuusLieben modified the milestones: 0.6.0, 0.7.0 Jul 31, 2024
@GuusLieben GuusLieben closed this Aug 1, 2024
@GuusLieben GuusLieben reopened this Aug 1, 2024
@GuusLieben GuusLieben force-pushed the feature/#1092-module-migration branch from 5529e1e to ffccdf8 Compare August 2, 2024 07:32
@GuusLieben GuusLieben force-pushed the feature/#1049-developer-documentation branch from 7463981 to 0092c51 Compare August 2, 2024 07:33
@GuusLieben GuusLieben force-pushed the feature/#1049-developer-documentation branch 4 times, most recently from 4616ecb to 5ec0407 Compare August 10, 2024 09:25
@GuusLieben GuusLieben force-pushed the feature/#1049-developer-documentation branch 4 times, most recently from 9bf1999 to 2f459ae Compare August 10, 2024 12:40
@GuusLieben GuusLieben force-pushed the feature/#1049-developer-documentation branch from 2f459ae to 70524d2 Compare August 10, 2024 12:40
@GuusLieben GuusLieben force-pushed the feature/#1049-developer-documentation branch from 9735ef3 to c50d24c Compare August 10, 2024 13:19
@GuusLieben GuusLieben merged commit 37b568e into feature/#1092-module-migration Aug 11, 2024
9 checks passed
@GuusLieben GuusLieben deleted the feature/#1049-developer-documentation branch August 11, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Migrate developer documentation to main repository
1 participant