Add dirty workaround for AST plugins in wrong order #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw, this PR is targeting the feature branch of #15, adding an additional commit. Just to be clear! |
cibernox
approved these changes
Jun 29, 2019
|
@simonihmig sorry for the delay, I've been detoxing from the computer. Merged! |
|
@simonihmig I came back today from holidays and I tested this but sadly it doesn't seem to work when installed in an addon: cibernox/ember-basic-dropdown#476 0.3.0 contains your changes. 0.4.0 is a re-publish of 0.2.0 reverting your changes. |
This was referenced Sep 27, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cibernox As I wanted to update to the latest
ember-in-element-polyfill, but without having to migrate away fromember-maybe-in-element, I took a look at the failing issue in #15 we talked about a while ago.I remembered that I had to do some trickery regarding the order of AST plugins for an older version of the polyfill, where it had some explicit support for
ember-maybe-in-element: https://github.com/kaliber5/ember-in-element-polyfill/blob/9aeec71d12dd6db9586097ffc11f94d30d6120cb/index.jsApplying the same tricks here seems to fix the issue!
And I certainly agree that this look ugly as hell, sorry about that! 😬