Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scope memory leak #168

Merged
merged 1 commit into from
Oct 25, 2018
Merged

Fix scope memory leak #168

merged 1 commit into from
Oct 25, 2018

Conversation

snewcomer
Copy link
Collaborator

@snewcomer snewcomer commented Oct 25, 2018

I'm seeing some memory leaks due to retained object in our intersection observer administrator.

The use of window as a key is causing memory to be retained between each test run.

@snewcomer snewcomer added the bug label Oct 25, 2018
@snewcomer snewcomer self-assigned this Oct 25, 2018
@snewcomer snewcomer merged commit 9e89c10 into master Oct 25, 2018
@snewcomer snewcomer deleted the sn/memory-leak branch October 25, 2018 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant