Use one IntersectionObserver per viewport #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snewcomer
changed the title
snewcomer
force-pushed
the
enhancement/sn/one-io
branch
from
d086720
to
e440884
Compare
Serabe
requested changes
Jul 23, 2018
addon/mixins/in-viewport.js
Outdated
| * @property _observerOptions | ||
| * @default {} | ||
| */ | ||
| _observerOptions: {}, |
There was a problem hiding this comment.
Null / computed returning empty object / initialize on init. This could lead to leaking state between objects implementing this mixin.
|
@jheth Hey 👋 Was curious if you could try this out (only if you have a free moment though; otherwise, no worries) and lmk if it still works for ya. This does something similar we did for rAF, but for IntersectionObserver - i.e. a static administrator to reuse an observer. |
|
Similar memory footprint for many use cases but if you have many different IntersectionObserver, then this should help slightly. Tested in a few different projects and all still seems well with the world. Lmk if anybody experiences any issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to use a service that utilizes IntersectionObserver's ability to observe multiple elements. Currently, we are instantiating a new IntersectionObserver per element on page. However, one optimization, especially in cases where many elements are beings watched (think advertisements or lazy loading hundreds of pictures), is simply use the same IntersectionObserver to watch multiple entries.
close #119