Fix viewportTolerance with defaults #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snewcomer
commented
Feb 7, 2018
| {{/my-component}} | ||
| `); | ||
|
|
||
| assert.equal(this.$().text().trim(), 'template block text'); |
There was a problem hiding this comment.
These tests are definitely not comprehensive, but would like to build on them. Also will add an acceptance test where there is a very large target element and set the intersectionObserver to 1.0 and ensure nothing is fired until scroll to bottom of target in a follow up PR.
| @@ -98,7 +98,7 @@ export default Mixin.create({ | |||
| } | |||
|
|
|||
| if (get(this, 'viewportUseIntersectionObserver')) { | |||
| const { top, left, bottom, right } = this.viewportTolerance; | |||
| const { top = 0, left = 0, bottom = 0, right = 0 } = this.viewportTolerance; | |||
There was a problem hiding this comment.
This fixes the root issue in the IntersectionObserver case.
|
Only one change to the in-viewport mixin. Will merge this morning if everybody is ok with this. |
|
Thanks so much @snewcomer - super quick reaction! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bkoval This is completely my fault. I didn't have a test for the
viewportTolerance.This is a small fix, but in reality there still are a few things we can still improve - better tests for viewportTolerance and intersectionThreshold, allow % for viewportTolerance in the IntersectionObserver case, etc. I'll make a follow up issue.
References #121