This repository has been archived by the owner on Oct 29, 2020. It is now read-only.
Applies bounce rate fix to international branch #5850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Drupal’s `hook_user_login` and `hook_user_insert` to add custom events to the following page load on login/registration.
This makes more sense, since hook_insert_user seems to be intended more for database-related changes. I've also split message broker logic into a new "private" method for better readability.
Login AND registration both previously used the `dosomething_user_login_submit` hook, which was confusing at first glance. This shuffles things around to have a shared `authentication` submit handler, and a unique `login` handler for the login form.
|
Looks good to me! 👍 |
sergiitk
added a commit
that referenced
this pull request
Nov 30, 2015
Applies bounce rate fix to international branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5846.