Gallery heading #530
Merged
Gallery heading #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an installation issue with old versions of node-sass.
|
It passes inspection! ⭐ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds an (optional!)
.gallery__headingelement to the Gallery pattern. This allows us to add headings that are properly "visually grouped" with their relevant gallery contents. References oldie-but-goodie DoSomethingArchive/legacy-website#4083.Also updates
grunt-sassversion because the old version ofnode-sasspackaged with the version we were using was having compile issues on El Capitan. Plus we get like new Sass features and stuff.Screenshots
For review: @DoSomething/front-end