Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal mini-refactor #434

Merged
merged 5 commits into from
Feb 4, 2015
Merged

Modal mini-refactor #434

merged 5 commits into from
Feb 4, 2015

Conversation

DFurnes
Copy link
Contributor

@DFurnes DFurnes commented Feb 4, 2015

Changes

  • Adds .modal__block element for adding padding in modals. This allows "full-width" modal content to work without a negative margin, and follows the same convention we use for container pattern.
  • Attach overlay to the chrome, rather than the modal container, so it doesn't scroll on Safari/iOS. This makes rubber-band scrolling look way better.
  • Refactors chrome modifiers (for mobile-menu and modals) to use standard state naming scheme.

For review: @DoSomething/front-end

@DFurnes
Refactor chrome modifiers to use standard state naming scheme.
8c8589c
@DFurnes
Use .modal__block to add padding in modals.
77c8275 
This allows "full-width" modal content to work without a negative
margin.
@DFurnes
Attach overlay to container, rather than modal container.
8765c4a 
This allows overflow scrolling to work nicely on Safari & iOS.
@DFurnes
Adjust overlay z-index to ensure it appears above all content.
cf38877
@DFurnes
Adjust box-shadow to ensure it doesn't hit edge of page.
3da5507 
The box-shadow won’t render out of page, so this creates a minor visual
glitch in Safari/iOS rubber band scrolling.
@weerd
Copy link
Contributor

weerd commented Feb 4, 2015

Looking cool 👍

DFurnes added a commit that referenced this pull request Feb 4, 2015
@DFurnes
Merge pull request #434 from DFurnes/modal-refactor
eff21c2 
Modal mini-refactor
@DFurnes DFurnes merged commit eff21c2 into DoSomethingArchive:dev Feb 4, 2015
@DFurnes DFurnes deleted the modal-refactor branch February 4, 2015 21:31
@DFurnes DFurnes mentioned this pull request Feb 9, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DFurnes @weerd