Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container... block! #412

Merged
merged 2 commits into from
Jan 29, 2015
Merged

Container... block! #412

merged 2 commits into from
Jan 29, 2015

Conversation

DFurnes
Copy link
Contributor

@DFurnes DFurnes commented Jan 29, 2015

Changes

  • Renames container__body to container__block, since it seems weird to have more than one "body" per container. Naming! 📦
  • Adds clearfix to container block to prevent blocks collapsing when they have floated content.

For review: @DoSomething/front-end

@DFurnes
Rename container__body to container__block.
8564113
@DFurnes
Add clearfix to container block.
6893295 
This fixes issues with the container collapsing with floated content &
losing correct padding. References DoSomethingArchive/legacy-website#3838.
@weerd
Copy link
Contributor

weerd commented Jan 29, 2015

🐑 IT!
👯

@DFurnes
Copy link
Contributor Author

DFurnes commented Jan 29, 2015

👊

DFurnes added a commit that referenced this pull request Jan 29, 2015
@DFurnes
Merge pull request #412 from DFurnes/container-block
e17121c 
Container... block!
@DFurnes DFurnes merged commit e17121c into DoSomethingArchive:dev Jan 29, 2015
@DFurnes DFurnes deleted the container-block branch April 1, 2015 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DFurnes @weerd