Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes styleguide nav issue in Chrome/IE. #408

Merged
merged 2 commits into from
Jan 23, 2015
Merged

Fixes styleguide nav issue in Chrome/IE. #408

merged 2 commits into from
Jan 23, 2015

Conversation

DFurnes
Copy link
Contributor

@DFurnes DFurnes commented Jan 23, 2015

Changes

  • Fixes issue where pesky sticky nav would escape(!) the page container in browsers that didn't support position: sticky. Yikes.

For review: @DoSomething/front-end

@DFurnes DFurnes changed the title Chrome styleguide nav issue Fixes styleguide nav issue in Chrome/IE. Jan 23, 2015
@weerd
Copy link
Contributor

weerd commented Jan 23, 2015

I didn't think I'd ever live to see the day where an issue overlapped on just these two browsers "Chrome/IE"...

@weerd
Copy link
Contributor

weerd commented Jan 23, 2015

👍

DFurnes added a commit that referenced this pull request Jan 23, 2015
@DFurnes
Merge pull request #408 from DFurnes/chrome-styleguide-nav-issue
193ae05 
Fixes styleguide nav issue in Chrome/IE.
@DFurnes DFurnes merged commit 193ae05 into DoSomethingArchive:dev Jan 23, 2015
@DFurnes DFurnes deleted the chrome-styleguide-nav-issue branch January 23, 2015 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DFurnes @weerd