Adjust modal close buttons to be sized with banners. #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| @@ -62,12 +62,16 @@ | |||
| position: absolute; | |||
| top: 0; | |||
| right: $base-spacing; | |||
| font-size: 45px; | |||
| font-size: 36px; | |||
There was a problem hiding this comment.
Should these font sizes correlate with the new font size variables you created with Neue 6?
There was a problem hiding this comment.
They're sort of hackish since they're for an icon rather than plain text, and also to compensate for the multiplication sign "close" button being a pretty small glyph compared to other characters.
DFurnes
added a commit
that referenced
this pull request
Jan 23, 2015
Adjust modal close buttons to be sized with banners.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Desktop:
Mobile: