Fix: during type inferencing, parse whitespace strings as NaN (dotnet…

…#271)
Dmitry-A · Mar 8, 2019 · 2ba9664 · 2ba9664
1 parent 2ea089e
commit 2ba9664
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/src/Microsoft.ML.Auto/Utils/MLNetUtils/Conversions.cs b/src/Microsoft.ML.Auto/Utils/MLNetUtils/Conversions.cs
@@ -19,7 +19,13 @@ internal static class Conversions
         public static bool TryParse(in TX src, out R4 dst)
         {
             var span = src.Span;
-            if (float.TryParse(span.ToString(), out dst))
+            var str = span.ToString();
+            if (string.IsNullOrWhiteSpace(str))
+            {
+                dst = R4.NaN;
+                return true;
+            }
+            if (float.TryParse(str, out dst))
             {
                 return true;
             }

diff --git a/src/Test/ColumnInferenceTests.cs b/src/Test/ColumnInferenceTests.cs
@@ -63,9 +63,9 @@ public void IdentifyLabelColumnThroughIndexWithoutHeader()
         [TestMethod]
         public void DatasetWithEmptyColumn()
         {
-            var result = new MLContext().Auto().InferColumns(Path.Combine("TestData", "DatasetWithEmptyColumn.txt"), DefaultColumnNames.Label);
+            var result = new MLContext().Auto().InferColumns(Path.Combine("TestData", "DatasetWithEmptyColumn.txt"), DefaultColumnNames.Label, groupColumns: false);
             var emptyColumn = result.TextLoaderOptions.Columns.First(c => c.Name == "Empty");
-            Assert.AreEqual(DataKind.String, emptyColumn.DataKind);
+            Assert.AreEqual(DataKind.Single, emptyColumn.DataKind);
         }
 
         [TestMethod]

diff --git a/src/Test/ConversionTests.cs b/src/Test/ConversionTests.cs
@@ -15,7 +15,8 @@ public void ConvertFloatMissingValues()
         {
             var missingValues = new string[]
             {
-                "?",
+                "",
+                "?", " ",
                 "na", "n/a", "nan",
                 "NA", "N/A", "NaN", "NAN"
             };