Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link for getting started #288

Closed
wants to merge 3 commits into from

Conversation

AnSavvides
Copy link

It looks like there are four entries for how_internet_works (one each for English, Spanish, Polish & Ukrainian?) - I am defaulting to the English one.

DjangoSprintLondon

It looks like there are four entries for `how_internet_works` (one each for English, Spanish, Polish & Ukrainian?) - I am defaulting to the English one.
@phalt
Copy link
Member

phalt commented Mar 22, 2015

👍 Good spot.

@phalt
Copy link
Member

phalt commented Mar 22, 2015

❓ Looking at this a bit more it seems that when browsing the docs on github this fixes the broken link, but I think gitbook works out the language for us and sets up the right link? @bmispelon would know more, I think.

@AnSavvides
Copy link
Author

Aha! I see! Let's see what @bmispelon has to say then. I will try entice him with some emoji: 🐱 🐍

@keikoro
Copy link

keikoro commented Mar 22, 2015

Is there a chance to correct how_internet_work to how_the_internet_works in the process? It's been bugging me from the beginning. :P

@AnSavvides
Copy link
Author

Sure thing! Makes perfect sense :P

@AnSavvides
Copy link
Author

@kerstin that's all done :)

@keikoro
Copy link

keikoro commented Mar 22, 2015

Cool! I just remembered there was something about this at some point in the past, so went looking for it after I wrote my comment.

It's #119 though I don't know what the exact problems (plural) were that were referred to in that issue except for broken links IF someone, somewhere had previously linked to only that one chapter. (Which I honestly think is unlikely, or at least wouldn't affect a myriad of people.)

Edit: Maybe that was about the rest of @bmispelon's pull request? (Not that single rename?)

@AnSavvides
Copy link
Author

Ah! Well, let's wait and see what @bmispelon and/or @olasitarska think :)

@aniav
Copy link
Member

aniav commented Mar 27, 2015

Ok, so we have two things here.

⚡ First is changing the link - I can't merge that. The links in gitbook are relative and are generated during build time. I have checked them - they work properly on gitbook. They won't always work properly here, especially for the main README.md file.

⚡ The second thing is adding the "the" in how_the_internet_works. I have added this in 80b38f1.

I am closing this pull request. Thank you all!

@aniav aniav closed this Mar 27, 2015
@AnSavvides
Copy link
Author

👍

@AnSavvides AnSavvides deleted the patch-1 branch March 28, 2015 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants