Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add class based login required #117

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

PabloLefort
Copy link

Use of login_required as a method decorator

@das-g
Copy link
Member

das-g commented Sep 21, 2024

Do any parts of the Django Girls tutorial or of the Django Girls tutorial extensions already use class-based views? (I couldn't find any.) If not, I'd say that this addition is out of scope for the Django Girls tutorial, which has the goal to provide detailed instructions on one way to do things (so that newcomers can follow), not to provide comprehensive documentation for all variants to do stuff. (The latter is what the official Django documentation and other resources are for).

@das-g
Copy link
Member

das-g commented Sep 21, 2024

On, and sorry for the long wait to get this reviewed. I've just resolved a trivial merge conflict that has come up since this PR was filed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants