This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
feat(default-theme): display 400 errors right from the API #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💙 shopware-pwa successfully deployed at https://d430480fec104b6cc21d6b858e61da6985b6c3e5.shopware-pwa.preview.storefrontcloud.io |
patzick
suggested changes
Apr 1, 2020
Comment on lines
83
to
84
| userError, | ||
| getMessagesFromErrorsArray |
There was a problem hiding this comment.
Suggested change
| userError, | |
| getMessagesFromErrorsArray | |
| userErrorMessages |
Comment on lines
94
to
102
| computed: { | ||
| useUserErrorMessages() { | ||
| // all the 400 errors are in a raw format stright from the API - to be extracted easily depeding on needs. | ||
| return ( | ||
| this.userError && | ||
| this.getMessagesFromErrorsArray(this.userError.message) | ||
| ) | ||
| } | ||
| }, |
There was a problem hiding this comment.
then we don't need this computed section in components
akrajna
suggested changes
Apr 1, 2020
mkucmus
commented
Apr 3, 2020
| methods: { | ||
| async invokeUpdate() { | ||
| const emailChanged = await this.updateEmail({ | ||
| email: this.email, | ||
| confirmEmail: this.confirmEmail, | ||
| emailConfirmation: this.confirmEmail, |
There was a problem hiding this comment.
@Michal-Dziedzinski tu jest fix
|
also closes; #416 |
thanks @akrajna 👍, could you create a new issue regarding this? |
patzick
approved these changes
Apr 9, 2020
patzick
deleted the
feat/consistent-api-errors-reporting-for-customer-#555
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #555
Checklist