1MB buffer on the stack?

[JahButNah]

I know you want speed, but you can't have my stack. In Visual C++ the default Stack Reserve Size is 1MB in virtual memory and the Stack Commit Size is 4KB in physical memory.
I had to hunt down the excessive stack request by climbing into your implementation.
StreamParser::StreamBuffer creates an NxN std::array with a default of N=1KiB.
Also, maybe StreamParser::StreamBuffer::fill() should use stream_.read(..., buffer_.size()) instead of duplicating the "N * N" from the std::array<...> definition.

Thanks for your attention.

[Disservin]

The StreamParser is templated and can be configured with the buffer size, so just define a lower value?

[Disservin]

the default could be lower though..

[JahButNah]

True. The squaring could be done without, though. It's only confusing.

…

On Sun, Apr 14, 2024 at 10:32 PM disservin ***@***.***> wrote: the default could be lower though.. — Reply to this email directly, view it on GitHub <#87 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BHRTUEF4NJF5R5RY5PPKLETY5KOPXAVCNFSM6AAAAABGGFJGKSVHI2DSMVQWIX3LMV43SRDJONRXK43TNFXW4Q3PNVWWK3TUHM4TCMBZHE3TI> . You are receiving this because you authored the thread.Message ID: ***@***.***>