fix(channel): improve handling of placeholder guilds in GuildChannel
and Thread
#1287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This avoids errors related to
Object
guilds on guild-dependent channel properties when used with user apps. Stubbing methods isn't ideal, but it's arguably better than throwingAttributeError
s at random.Closely related to #1236, the future of which is still very much undecided at this point.
(context: since interactions don't receive a (proper) guild object, we generally substitute it for
Object
if necessary. This works fine:tm: for the most part, but some properties (rightfully) expect an actualGuild
object)Checklist
pdm lint
pdm pyright