Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(state): prevent DeprecationWarning on shard reconnect #1267

Merged
merged 2 commits into from
Dec 29, 2024

Conversation

shiftinv
Copy link
Member

Summary

Rebinding guild/member references on shard reconnect also updates Message.interaction.user; interaction is deprecated, so this should use the underlying _interaction instead to avoid copious amounts of DeprecationWarnings (one per cached message).

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added this to the disnake v2.11 milestone Dec 29, 2024
@shiftinv shiftinv merged commit 01cf7f3 into master Dec 29, 2024
30 of 31 checks passed
@shiftinv shiftinv deleted the fix/state-interaction-warning branch December 29, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant