Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement subscriptions and update the premium apps API #1258

Merged
merged 19 commits into from
Dec 29, 2024
Merged

feat: implement subscriptions and update the premium apps API #1258

merged 19 commits into from
Dec 29, 2024

Conversation

Snipy7374
Copy link
Collaborator

@Snipy7374 Snipy7374 commented Dec 14, 2024 •
edited
Loading

Summary

Note: I still need to implement the async iterator for SKU.subscriptions

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added t: enhancement New feature t: api support Support of Discord API features labels Dec 14, 2024
@Snipy7374 Snipy7374 requested a review from shiftinv December 16, 2024 09:48
shiftinv
shiftinv reviewed Dec 21, 2024
View reviewed changes
disnake/entitlement.py Outdated Show resolved Hide resolved
disnake/sku.py Outdated Show resolved Hide resolved
disnake/subscription.py Outdated Show resolved Hide resolved
disnake/subscription.py Outdated Show resolved Hide resolved
disnake/subscription.py Outdated Show resolved Hide resolved
disnake/subscription.py Outdated Show resolved Hide resolved
disnake/subscription.py Outdated Show resolved Hide resolved
disnake/subscription.py Outdated Show resolved Hide resolved
Snipy7374 and others added 6 commits December 21, 2024 23:20
@Snipy7374 @shiftinv
Update disnake/subscription.py
2c46b96 
Co-authored-by: vi <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: Snipy7374 <100313469+Snipy7374@users.noreply.github.com>
@Snipy7374 @shiftinv
Update disnake/subscription.py
a84f1ea 
Co-authored-by: vi <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: Snipy7374 <100313469+Snipy7374@users.noreply.github.com>
@Snipy7374 @shiftinv
Update disnake/subscription.py
187dd8f 
Co-authored-by: vi <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: Snipy7374 <100313469+Snipy7374@users.noreply.github.com>
@Snipy7374 @shiftinv
Update disnake/subscription.py
5699c71 
Co-authored-by: vi <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: Snipy7374 <100313469+Snipy7374@users.noreply.github.com>
@Snipy7374 @shiftinv
Update disnake/subscription.py
d4e92a1 
Co-authored-by: vi <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: Snipy7374 <100313469+Snipy7374@users.noreply.github.com>
@Snipy7374 @shiftinv
Update disnake/subscription.py
b3c92a6 
Co-authored-by: vi <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: Snipy7374 <100313469+Snipy7374@users.noreply.github.com>
shiftinv
shiftinv reviewed Dec 22, 2024
View reviewed changes
disnake/iterators.py Outdated Show resolved Hide resolved
shiftinv
shiftinv reviewed Dec 25, 2024
View reviewed changes
disnake/enums.py Outdated Show resolved Hide resolved
Snipy7374 and others added 5 commits December 25, 2024 16:31
@Snipy7374 @shiftinv
Update disnake/enums.py
d7bea2d 
Co-authored-by: vi <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: Snipy7374 <100313469+Snipy7374@users.noreply.github.com>
@Snipy7374 @shiftinv
Update disnake/entitlement.py
7770e2d 
Co-authored-by: vi <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: Snipy7374 <100313469+Snipy7374@users.noreply.github.com>
@Snipy7374
Merge branch 'master' into sku_migration
3f0f1d2 
Signed-off-by: Snipy7374 <100313469+Snipy7374@users.noreply.github.com>
@Snipy7374
make user required to fetch subscriptions
7fc659a
@Snipy7374
Merge branch 'sku_migration' of github.com:Snipy7374/disnake into sku…
791fa72 
…_migration
@Snipy7374 Snipy7374 requested a review from shiftinv December 26, 2024 21:44
@shiftinv shiftinv added this to the disnake v2.10 milestone Dec 28, 2024
shiftinv
shiftinv approved these changes Dec 29, 2024
View reviewed changes
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@shiftinv shiftinv merged commit 6cde332 into DisnakeDev:master Dec 29, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftinv shiftinv shiftinv approved these changes

Assignees
No one assigned
Labels
t: api support Support of Discord API features t: enhancement New feature
Projects
disnake
Status: Done
Milestone
disnake v2.10
Development

Successfully merging this pull request may close these issues.

SKU + Entitlement API is outdated
2 participants
@Snipy7374 @shiftinv