-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement __eq__
between BaseFlags and flag_values
#1238
Conversation
I think this could go a step further and make |
See Enegg@2cbd98e |
@Enegg Yea, this has come up once or twice, it would be a good thing in the long run. In an ideal world, flags would probably just be a special type of enum, like they are in the stdlib. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
Summary
This PR adds support for
__eq__
comparison betweenBaseFlags
andflag_values
.For example,
Checklist
pdm lint
pdm pyright