Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feet(:foot:): improve the subpar #1170

Closed
wants to merge 5 commits into from
Closed

feet(:foot:): improve the subpar #1170

wants to merge 5 commits into from

Conversation

EnokiUN
Copy link

@EnokiUN EnokiUN commented Mar 19, 2024

Summary

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@EnokiUN
Copy link
Author

EnokiUN commented Mar 19, 2024

I accidentally pressed enter while doing title emoji

@Sharp-Eyes
Copy link
Member

I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT I DON'T CONSENT

@shiftinv shiftinv added the p: high High priority label Mar 19, 2024
@ooliver1
Copy link

This truly improves the subpar :neckbeard:

@EnokiUN EnokiUN requested a review from a team as a code owner March 19, 2024 22:34
@shiftinv
Copy link
Member

This is truly one of the PRs of all time, thank you so much for the contribution.

Unfortunately, after thorough discussion with all maintainers, we've decided to decline your PR - it has left several files intact and, as such, isn't a suitable code style change.

@shiftinv shiftinv closed this Mar 19, 2024
@EnokiUN
Copy link
Author

EnokiUN commented Mar 19, 2024

This is truly one of the PRs of all time, thank you so much for the contribution.

Unfortunately, after thorough discussion with all maintainers, we've decided to decline your PR - it has left several files intact and, as such, isn't a suitable code style change.

what files, please give me another chance please I'll try to fix this

@Victorsitou
Copy link
Member

lgtm

@elenakrittik
Copy link
Contributor

i legitimately thought it's april first already after seeing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ooliver1 ooliver1 ooliver1 approved these changes

Assignees
No one assigned
Labels
p: high High priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@EnokiUN @Sharp-Eyes @ooliver1 @shiftinv @Victorsitou @elenakrittik