Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(message): include member data in InteractionReference.user #1160

Merged
merged 5 commits into from
Aug 24, 2024

Conversation

shiftinv
Copy link
Member

@shiftinv shiftinv commented Feb 24, 2024

Summary

Previously, message.interaction.user was just a User; the d["interaction"]["member"] data present in MESSAGE_CREATE/_EDIT is now used to turn this into a User | Member instead.

Fairly old apidocs change, seems like it was missed back then: discord/discord-api-docs@56cea94

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added t: enhancement New feature t: api support Support of Discord API features p: low Low priority labels Feb 24, 2024
@shiftinv shiftinv added this to the disnake v2.10 milestone Feb 24, 2024
Copy link
Contributor

@Skelmis Skelmis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@shiftinv
Copy link
Member Author

shiftinv commented Aug 9, 2024

It's worth mentioning that message["interaction"] has been deprecated in favor of message["interaction_metadata"].
Since interaction_metadata unfortunately doesn't include member data, and because the interaction code handles missing values no matter what, it's fine to implement this regardless for now.

@shiftinv shiftinv merged commit 0a5ab1e into master Aug 24, 2024
28 checks passed
@shiftinv shiftinv deleted the feature/interactionreference-member branch August 24, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: low Low priority t: api support Support of Discord API features t: enhancement New feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants