Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Use madagascar Recipes to do cre gather stack #43

Closed
Dirack opened this issue Sep 12, 2020 · 0 comments · Fixed by #53
Closed

[FEA] Use madagascar Recipes to do cre gather stack #43

Dirack opened this issue Sep 12, 2020 · 0 comments · Fixed by #53
Assignees
@Dirack
Labels
enhancement New feature or request
Milestone
v2.0

Comments

@Dirack
Copy link
Owner

Dirack commented Sep 12, 2020 •
edited
Loading

🎉 Feature request

Is your feature request related to a problem? Please describe.

The official repository of the Madagascar package has kimodel.py and pefInterpolation.py recipes already. So, the creGatherStack package does not need to use creStack.py python script in order to define modeling and interpolation functions.

Describe the solution you'd like

Update creGatherStack experiments to use those recipes directly from Madagascar local version.

Additional context
@Dirack Dirack added the enhancement New feature or request label Sep 12, 2020
@Dirack Dirack added this to the v2.0 milestone Sep 12, 2020
@Dirack Dirack self-assigned this Sep 12, 2020
Dirack added a commit that referenced this issue Sep 12, 2020
@Dirack
Add pefInterpolation.py recipe to the experiments #43
3cdc48c 
Changes pefInterpolation function calling from fullInterpolationAndStack
experiments.

The pefInterpolation.py recipe is now part of official Madagascar
package. Because of that, SConstruct can call it from local Madagascar
installation.
Dirack added a commit that referenced this issue Sep 12, 2020
@Dirack
Delete error report function calling #43
3617fe9 
Error report function was deleted from official repository
because it makes building and error report slow. Use python
logging functions to report errors in SCons
Dirack added a commit that referenced this issue Sep 12, 2020
@Dirack
All the work in SConstruct and use Madagascar recipes #43
1a29294 
The building of the experiment is splitted in several SConscripts.
Concatenate all the building steps in one SConstruct. And use the
Madagascar recipes 'kimodel.py' and 'pefInterpolation.py'.

Those recipes are available in the official Madagascar package
repository on github. Because of that they can be called from
SConstruct.
Dirack added a commit that referenced this issue Sep 12, 2020
@Dirack
Remove old recipes Resolve #43
44d8eb9 
Because those recipes are available in Madagascar package
it is no longer require to store a copy of then in this repository
@Dirack Dirack closed this as completed Sep 12, 2020
@Dirack Dirack mentioned this issue Sep 21, 2020
Merged
4 tasks
@Dirack Dirack linked a pull request Sep 21, 2020 that will close this issue
Develop/2.0 #53
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dirack Dirack

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

Develop/2.0 Dirack/creGatherStack
1 participant
@Dirack