Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all broken links in docs #365

Merged
merged 11 commits into from
Jan 28, 2025
Merged

Conversation

ealmloff
Copy link
Member

@ealmloff ealmloff commented Dec 31, 2024

This PR fixes all broken links that are caught by DioxusLabs/include_mdbook#15. It relies on the fix in DioxusLabs/dioxus#3484. It should only be merged after both PRs are merged

@ealmloff ealmloff added the bug Something isn't working label Jan 8, 2025
@ealmloff ealmloff marked this pull request as ready for review January 8, 2025 17:40
@ealmloff ealmloff mentioned this pull request Jan 16, 2025
@jkelleyrtp
Copy link
Member

jkelleyrtp commented Jan 27, 2025

I noticed that active_class seems broken with the new empty hash parameters. That seems like a bug in Link {}.

Why are we tacking on empty hash parameters anyways? I feel like our links should be "clean" and not attach the # segment if it's not necessary.

@jkelleyrtp jkelleyrtp merged commit 9591eb5 into DioxusLabs:main Jan 28, 2025
1 check passed
@jkelleyrtp
Copy link
Member

Merging this will slightly break the docsite (extra # on every link) but that needs to be fixed in dioxus itself in

DioxusLabs/dioxus#3658

@ealmloff ealmloff mentioned this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants