-
-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #55
Update README.md #55
Conversation
Given the previous statement, I can only hope, that this is what was meant. Godspeed developing this library, great work so far
Thanks! I haven't figured out how to get the "desktop" feature enabled by default when running examples, so you have to manually specify the |
I am rather unfamiliar with these settings. Though I think for something like a GUI library it makes sense to turn on all features by default and manually turning them of can be done as an optimization. Is it possible to structure code like this in general? |
I'm not too sure if it's possible. At least, cargo doesn't support that, so we'd need to create a new "examples" crate in the workspace that has all those features enabled. So instead of having to pass the I know repositories that do both. Though, we might be able to patch .cargo/config.toml with a custom runner that always has those features. |
I'd prefer to to enable some/all features by default, it seems to be possible: https://doc.rust-lang.org/cargo/reference/features.html#the-default-feature I think it makes "just getting started" with this crate tremendously easier and disabling features is still a useful fine-tuning step. This would also make running the examples easier. Option 2: Maybe create a custom run command? |
Update! I did not know you could do this, but you can infact put the current crate as its own dev dependency with features enabled. [dev-dependencies]
dioxus = { path = ".", features = ["desktop", "ssr", "router"] } I'm going to close your PR and then make a new one that implements this change and simplifies the running process. Good suggestion! |
fix single line rsx hot reloading
Given the previous statement, I can only hope, that this is what was meant. Godspeed developing this library, great work so far