Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove version pin on tao #3485

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

sehnryr
Copy link
Contributor

@sehnryr sehnryr commented Jan 2, 2025

Version 0.30.3 of tao includes the fix for the window resize issue on Wayland.

Fixes #3314

0.30.3 includes the fix for the resize issue DioxusLabs#3314
@jkelleyrtp
Copy link
Member

jkelleyrtp commented Jan 2, 2025

This is a bit unfortunate - tao is part of our public API and bumping it would be a breaking change (ie 0.6 -> 0.7). A long-term way of fixing this would for dioxus to get onto a 1.0.0 so we could use the minor version for dependency upgrades or removing tao from our public API altogether (which we need to do for winit, eventually).

Is there a way we can address the tao bug without bumping tao?

Alternatively we could yank dioxus-desktop 0.6.0 and 0.6.1 and simply force everyone onto the new, fixed tao, but that would might also require yanking dioxus 0.6.0 / 0.6.1? If we yanked dioxus-desktop then I think the crates resolver would always just choose the new one.

instead on including 0.31.0 as a breaking change, removing the pin upgrades tao automatically to 0.30.8
@sehnryr sehnryr changed the title upgrade tao from 0.30.0 to 0.31.0 remove version pin on tao Jan 2, 2025
Copy link
Member

@jkelleyrtp jkelleyrtp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkelleyrtp jkelleyrtp merged commit 0ffa91d into DioxusLabs:main Jan 2, 2025
17 checks passed
@sehnryr sehnryr deleted the fix/wayland-window-resize branch January 2, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't move or resize window on Gnome + Wayland
2 participants