Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add helpful message for obscure cargo failures #3380

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

jkelleyrtp
Copy link
Member

@jkelleyrtp jkelleyrtp commented Dec 17, 2024

If cargo build ends in a weird state, we were previously swallowing logs (which has been fixed).

However, we should still point people to enabling trace mode in these cases since there might be useful information.

This also removes a latent info!() log that isn't helpful.

@jkelleyrtp jkelleyrtp merged commit 040dc54 into main Dec 17, 2024
15 of 17 checks passed
@jkelleyrtp jkelleyrtp deleted the jk/logging-tweaks branch December 17, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant