Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fullstack build bug when --release #3078

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

hackartists
Copy link
Contributor

  • rust 1.82.0 doesn't allow custom profile when release build
  • Below command always cause panic from cargo due to using profile with release
dx build -p platform --release

* rust 1.82.0 doesn't allow custom profile when release build
Copy link
Member

@DogeDark DogeDark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DogeDark DogeDark merged commit 306fbe2 into DioxusLabs:main Oct 20, 2024
17 checks passed
@nigeleke
Copy link

nigeleke commented Oct 27, 2024

Can I confirm this is fixed. I stll get the issue (or a similar issue??).

Using the "current" git repo dioxus-cli (as at 27-Oct 10:30 GMT) I get the following issue when attempting a release build:

Installed package `dioxus-cli v0.6.0-alpha.3 (https://github.com/DioxusLabs/dioxus.git#6c69c290)` (executable `dx`)

$ dx build --release
error: the argument '--profile <PROFILE-NAME>' cannot be used with '--release'

Usage: cargo rustc --message-format <FMT> --profile <PROFILE-NAME> --target [<TRIPLE>] --quiet --bin [<NAME>] [ARGS]...

For more information, try '--help'.
Error: 🚫 Building project failed:

Caused by:
    Build did not return an executable

$ rustc --version
rustc 1.84.0-nightly (798fb83f7 2024-10-16)

Cargo.toml is

[package]
name = "scopa"
version = "0.1.36"
authors = ["Nigel Eke <nigeleke@gmail.com>"]
edition = "2021"

[dependencies]
dioxus = { git = "https://github.com/DioxusLabs/dioxus.git", features = ["web", "asset"] }
dioxus-logger = "0.5.1"
getrandom = { version = "0.2.15", features = ["js"] }
thiserror = "1.0.63"
uuid = { version = "1.10.0", features = ["v4"] }

@DogeDark
Copy link
Member

We merged a big PR that was started before this one was merged so it could've been overwritten. I'll look into this today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants