Move the document trait into a separate crate #3035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealmloff
changed the title
ealmloff
changed the title
ealmloff
force-pushed
the
document-trait-crate
branch
from
4b94b3b to
0a635a1
Compare
ealmloff
added
organization
jkelleyrtp
force-pushed
the
document-trait-crate
branch
from
d2b6da2 to
c5a4408
Compare
jkelleyrtp
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls out just the changes needed for the document crate from #2972 without removing async support from eval
The router will likely be a super trait of the document, but I need to think a bit more about how that design works for non-html renderers first. That will likely be included in a follow up PR