Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse trailing route slash #2896

Merged
merged 4 commits into from
Sep 7, 2024
Merged

Parse trailing route slash #2896

merged 4 commits into from
Sep 7, 2024

Conversation

ealmloff
Copy link
Member

The router currently accepts /path/ if you try define the route route("/path"), but it doesn't accept /path if you define the route route("/path/"). This PR accepts both variants and adds more tests for parsing

@ealmloff ealmloff added bug Something isn't working router Related to the router implementation labels Aug 27, 2024
@ealmloff ealmloff merged commit 7bb53fe into DioxusLabs:main Sep 7, 2024
15 checks passed
@matthunz matthunz mentioned this pull request Nov 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthunz matthunz matthunz approved these changes

Assignees
No one assigned
Labels
bug Something isn't working router Related to the router implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ealmloff @matthunz