Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix suspense diffing #2789

Merged
merged 4 commits into from
Aug 6, 2024
Merged

Fix suspense diffing #2789

merged 4 commits into from
Aug 6, 2024

Conversation

ealmloff
Copy link
Member

@ealmloff ealmloff commented Aug 5, 2024

Fixes #2783

@ealmloff ealmloff added bug Something isn't working core relating to the core implementation of the virtualdom labels Aug 5, 2024
@ealmloff ealmloff marked this pull request as draft August 6, 2024 01:48
@ealmloff ealmloff marked this pull request as ready for review August 6, 2024 18:02
jkelleyrtp
jkelleyrtp approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@jkelleyrtp jkelleyrtp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess it was a race condition with pulling nodes out and diffing them? Good find.

@jkelleyrtp jkelleyrtp merged commit 37ea8ab into DioxusLabs:main Aug 6, 2024
15 checks passed
@ealmloff ealmloff deleted the fix-suspense-swap branch August 6, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkelleyrtp jkelleyrtp jkelleyrtp approved these changes

Assignees
No one assigned
Labels
bug Something isn't working core relating to the core implementation of the virtualdom
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suspense diffing fails when switching components on the client
2 participants
@ealmloff @jkelleyrtp